Draw the faxes - #21
Merged
Merged
Conversation
reader v0.5.0 decodes /CCITTFaxDecode. 67 of the 1 633 real forms in the corpus carry a fax and 6 of their pages have nothing else on them, so those pages drew blank; requiring an older reader here would leave them blank for anyone who asked only for this package, since minimum version selection gives them the version this go.mod names. fax_test.go guards it with a fax rather than a version string: one Group 4 row, three white pixels then five black, coded in horizontal mode and built in the test so nobody else's scan enters the repository. Against reader v0.4.2 it fails with "the black part of the fax is not black: (6,4) = 255,255,255,255". Measured through this package over the first page of all 1 633 real forms, 69 pages change: one from blank to drawn (fr-cerfa/cerfa_11818, 0 inked pixels to 28 989), fourteen with more ink, and fifty-one with less — those were showing their own compressed bytes as a stencil, which #20 stopped and this finishes. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reader v0.5.0 decodes /CCITTFaxDecode. 67 of the 1 633 real forms in the corpus
carry a fax and 6 of their pages have nothing else on them, so those pages drew
blank; requiring an older reader here would leave them blank for anyone who
asked only for this package, since minimum version selection gives them the
version this go.mod names.
fax_test.go guards it with a fax rather than a version string: one Group 4 row,
three white pixels then five black, coded in horizontal mode and built in the
test so nobody else's scan enters the repository. Against reader v0.4.2 it fails
with "the black part of the fax is not black: (6,4) = 255,255,255,255".
Measured through this package over the first page of all 1 633 real forms, 69
pages change: one from blank to drawn (fr-cerfa/cerfa_11818, 0 inked pixels to
28 989), fourteen with more ink, and fifty-one with less — those were showing
their own compressed bytes as a stencil, which #20 stopped and this finishes.